hkaiser changed the topic of #ste||ar to: STE||AR: Systems Technology, Emergent Parallelism, and Algorithm Research | stellar-group.org | HPX: A cure for performance impaired parallel applications | github.com/STEllAR-GROUP/hpx | This channel is logged: irclog.cct.lsu.edu
hkaiser has quit [Ping timeout: 260 seconds]
hkaiser has joined #ste||ar
K-ballo has quit [Ping timeout: 265 seconds]
diehlpk has joined #ste||ar
hkaiser has quit [Quit: Bye!]
Yorlik_ has joined #ste||ar
Yorlik has quit [Ping timeout: 260 seconds]
diehlpk has quit [Quit: Leaving.]
tufei has quit [Remote host closed the connection]
tufei has joined #ste||ar
Yorlik_ is now known as Yorlik
K-ballo has joined #ste||ar
hkaiser has joined #ste||ar
diehlpk has joined #ste||ar
diehlpk has quit [Client Quit]
bhumit[m]1 has joined #ste||ar
<hkaiser>
ms[m]: good thinking on the thread_init_data/thread_data comment! this is worth investigating as a separate PR, definitely.
<jedi18[m]>
hkaiser: I can't see your replies on github for some reason (can see the email though) so I'll reply here
<jedi18[m]>
I think you should evaluate is_same first before looking at is_sized_sentinel - I initially considered that but if it's not a sized sentinel, won't we have to loop through all elements anyway to get the distance right? So even if it's the same type as the iterator we'd still have to use the loop
<hkaiser>
no, if the iterators are random access and are the same they might not make is_sized_sentinel true
<jedi18[m]>
Ohh ok, I'll add the is_same check first then
<hkaiser>
same is true for your new distance implementation
<jedi18[m]>
Yeah, will make the change there too, thanks!