<ms[m]>
freenode_gonidelis[m]: the pycicle errors no, the windows github actions failures do look like they're caused by your changes though...
<ms[m]>
you may be missing a HPX_EXPORT or something like that in one of your files
<gonidelis[m]>
ms[m]: hmm What's the purpose of HPX_EXPORT?
hkaiser has joined #ste||ar
<ms[m]>
freenode_gonidelis[m]: it tells the linker that that symbol should be public in a shared library, otherwise the symbol will be in the shared library but hidden for linking (it can still be referenced within the shared library)
<ms[m]>
(note that I'm not sure that's your actual problem, I was just guessing based on the error message and the fact that windows tends to be stricter with exporting things correctly)
<hkaiser>
ms[m]: I don't think this is a import/export problem
<hkaiser>
I'd assume those types are header only
<hkaiser>
I rather think that this is caused by a mismatch between the partitioned and non-partitioned overloads for for_each_() (note the '_')
<hkaiser>
or a mismatch between declaration of said function and its definition
kale[m] has quit [Ping timeout: 272 seconds]
kale[m] has joined #ste||ar
<hkaiser>
ms[m]: would you mind if we merged #4527 at some point?
<ms[m]>
hkaiser: no, not at all
<ms[m]>
I was just waiting for it to be ok to merge
<hkaiser>
gonidelis[m]: not sure, I have not looked closely - all I know is that that the overloads should match (except for the is_segmented argument)
<hkaiser>
also, the function is declared and defined in different places, those should match as well
<gonidelis[m]>
ok should I try change the segmented version(s) and see if the tests pass? If that does not work we could rewind back to the last existing commit?
<hkaiser>
gonidelis[m]: I don't see an implementation for for_each_() (non-segmented) anymore
<hkaiser>
ahh, got it now
<gonidelis[m]>
I have not touched the segmented one
nanmiao11 has joined #ste||ar
<gonidelis[m]>
hkaiser: Plus, I think I need to use `is_sentinel_for`. Seems like I missed it. Is that right?
<hkaiser>
gonidelis[m]: is_sentinel_for would just properly constrain the arguments, it's not causing the linker error
<gonidelis[m]>
yeah I know. I am just asking wether I should add it in general, despite the errors.
<hkaiser>
gonidelis[m]: wrt the segmented version of for_each_: you might want to add the second template argument there (without changing the implementation), that could resolve the linker problem
<gonidelis[m]>
hkaiser: will do it right now
<gonidelis[m]>
hkaiser: ok just pushed. let's wait for the tests and see
karame_ has quit [Remote host closed the connection]
nikunj97 has joined #ste||ar
<hkaiser>
gonidelis[m]: we don't need to protect our internal implementation functions
<hkaiser>
only the user-facing API functions
<gonidelis[m]>
hkaiser: thanks
<gonidelis[m]>
hkaiser: Just added `is_sentinel_for`. I don't think that there is any other fix that needs to be done. Should I work on some other algo as we wait for the tests to be completed?
<hkaiser>
as you wish
<gonidelis[m]>
hkaiser: any suggestions?
<hkaiser>
any iteration based algo: copy, transform, etc.
nikunj97 has quit [Read error: Connection reset by peer]
hkaiser has quit [Quit: bye]
kale[m] has quit [Ping timeout: 246 seconds]
<weilewei>
ok, so after replace openblas with netlib-lapack in DCA on Piz Daint, hpx runs fine. I suspect some threading issues behind it. So netlib-lapack might be our good friend. Similarly, essl is not working with hpx on Summit
kale[m] has joined #ste||ar
nikunj97 has joined #ste||ar
Nikunj__ has joined #ste||ar
nikunj97 has quit [Ping timeout: 260 seconds]
nikunj has quit [Read error: Connection reset by peer]
nikunj has joined #ste||ar
kale[m] has quit [Ping timeout: 260 seconds]
kale[m] has joined #ste||ar
<bita_>
is there a flag to suppress hpx deprecated warnings?
<K-ballo>
depends on the deprecated thing
<bita_>
headers?
<weilewei>
HPX_WITH_DEPRECATION_WARNINGS ?
<bita_>
warning: "The header hpx/runtime/get_num_localities.hpp is deprecated, please include hpx/runtime.hpp instead" [-W#warnings]
<bita_>
#warning "The header hpx/runtime/get_num_localities.hpp \
<bita_>
weilewei, I tried that, but didn't work :o
<K-ballo>
can't you just fix the code?
<weilewei>
bita_ if it doesn't stop compilation, does it matter?