K-ballo changed the topic of #ste||ar to: STE||AR: Systems Technology, Emergent Parallelism, and Algorithm Research | stellar.cct.lsu.edu | HPX: A cure for performance impaired parallel applications | github.com/STEllAR-GROUP/hpx | Buildbot: http://rostam.cct.lsu.edu/ | Log: http://irclog.cct.lsu.edu/
hkaiser has joined #ste||ar
hkaiser has quit [Quit: bye]
<rainmaker6[m]> Please someone approve the workflows on https://github.com/STEllAR-GROUP/hpx/pull/5278
K-ballo has quit [Quit: K-ballo]
diehlpk_work has quit [Remote host closed the connection]
<rainmaker6[m]> * Please approve the workflows on https://github.com/STEllAR-GROUP/hpx/pull/5278
<rainmaker6[m]> * Please enable/approve ci testing on https://github.com/STEllAR-GROUP/hpx/pull/5278
<gonidelis[m]> ms[m]: yt?
RostamLog has joined #ste||ar
K-ballo has joined #ste||ar
<ms[m]> gonidelis[m]: sorry, here now
hkaiser has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
diehlpk_work has joined #ste||ar
bita has joined #ste||ar
<ms[m]> diehlpk_work: did we already have a (n internal) gsod mailing list? I wanted to share the applications before the meeting tomorrow
<gonidelis[m]> ms[m]: about those includes
<gonidelis[m]> `#include <hpx/hpx_main.hpp>`
<gonidelis[m]> if I don't have them I get an `hpx namespace not found` error
<gonidelis[m]> i first tried including the `hpx/iterator_support/iterator_traits` header
<gonidelis[m]> but that didn't solve the issue
hkaiser has joined #ste||ar
<srinivasyadav227> hkaiser: now i am a bit confused to what acutally do https://github.com/STEllAR-GROUP/hpx/pull/5319#discussion_r631079476 here, :), can you please tell what changes do i need make..?
<ms[m]> gonidelis[m]: you'll need to give me a bit more, what exactly triggers "hpx namespace not found" and why is hpx/hpx_main.hpp the right header to include for that? you're aware of what hpx_main.hpp does, right?
<ms[m]> srinivasyadav227: sorry for the noise there :P I just commented saying we can leave it as it is
<ms[m]> unless hkaiser changed his mind on that
<srinivasyadav227> ms: ok thanks :)
<hkaiser> ms[m]: on what should I have changed my mind? ;-)
<ms[m]> on that macro definition :P at least I understood your comment as saying you think the version with the identity is the better option
<ms[m]> both have weird corner cases, so I don't really mind which one we have
<ms[m]> hkaiser: question also for you: did we have an internal gsod mailing list where I could share the applications? I put the form on the contact@stellar-group.org google account, but I don't remember if anyone else has the password for it
<hkaiser> nod, let's go with the version that uses identify
<srinivasyadav227> ok, then changing the name of macro from HPX_HAVE_CXX20_STD_LAMBDA_CAPTURE to HPX_HAVE_CXX20_LAMBDA_CAPTURE would be sufficient right?
<hkaiser> ms[m]: we can create a mailing list, if you want - alternatively we could use the gsoc-mentors list
<ms[m]> hkaiser: ah, yeah, gsoc-mentors will do, thanks!
<ms[m]> if there's too much noise we can still create a gsod-mentors one later
<K-ballo> srinivasyadav227: did you find a way to make the feature test actually fail?
<srinivasyadav227> no
<K-ballo> a feature test case that always passes isn't really useful
bita has quit [Ping timeout: 245 seconds]
<srinivasyadav227> yea, true :), but that feature test is throwing a warning when manually compiled with `g++ -std=c++14/17` but i am not clear how that can be turned into an error, after reading this (https://github.com/STEllAR-GROUP/hpx/pull/5319#discussion_r630197167) comment many times from yesterday, today i understood and so i tried this(https://godbolt.org/z/vqdexxsqK) but it did not work out, so i am still trying to figure
<srinivasyadav227> this out. ;-)
<ms[m]> srinivasyadav227: I had a quick try and it seems like that warning is not controlled by any -W flag (at least for GCC, clang has one c++20 related flag that might do the trick)
<ms[m]> if you can find a way to just generally set -Werror for the feature test that might work (I don't remember if we have a way to set compiler flags on the compile tests though)
<srinivasyadav227> okay i will try that
<srinivasyadav227> with clang its `-Wc++20-extensions` here https://godbolt.org/z/e1qWasaPf
<srinivasyadav227> gcc seems to have no other way than passing `-Wall` to compiler ;-( , i could find any info about lamda capture (this) warning here https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
<K-ballo> the warning itself includes the corresponding flag, when one exists
bita has joined #ste||ar
<ms[m]> K-ballo: right, that's the problem, "when one exists"
<ms[m]> in this case there is no corresponding flag
<K-ballo> there's an argument to be made that feature tests should all compile with warnings as errors anyhow
<ms[m]> yep, that's a fair point
<K-ballo> I remember fixing some warnings ages ago, but not all, something got in the way of setting warnings as errors
<K-ballo> also curious that -Werror=aligned-new doesn't work, sounds like a plain bug
bita has quit [Ping timeout: 250 seconds]
jehelset has quit [Remote host closed the connection]
nanmiao has quit [Quit: Connection closed]
nanmiao has joined #ste||ar
nanmiao has quit [Quit: Connection closed]
hkaiser has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
jaafar_ has joined #ste||ar
jaafar_ is now known as jaafar