K-ballo changed the topic of #ste||ar to: STE||AR: Systems Technology, Emergent Parallelism, and Algorithm Research | stellar.cct.lsu.edu | HPX: A cure for performance impaired parallel applications | github.com/STEllAR-GROUP/hpx | Buildbot: http://rostam.cct.lsu.edu/ | Log: http://irclog.cct.lsu.edu/
hkaiser has quit [Quit: bye]
hkaiser has joined #ste||ar
bita has joined #ste||ar
bita has quit [Ping timeout: 264 seconds]
<gonidelis[m]>
hkaiser: did you see my comments on #5125 ?
<hkaiser>
sec
<gonidelis[m]>
i am pretty unsure about the iter-sent cases in general
<gonidelis[m]>
i am planning to add a test (actually I already did) but it hits on `first* = std::move(iter)` by saying `first*` needs to be an lvalue
<hkaiser>
is it*first = ... ?
<hkaiser>
also, as said, I'd need to see the full thing to tell what's wrong
<gonidelis[m]>
but what I am trying to says is: shouldn't we start providing some tests for all the adapted algos so far about the iter-sent cases? Do you think that it is better to do that after all algos have been adapted?
<hkaiser>
gonidelis[m]: yes, that might be a good idea
<gonidelis[m]>
hkaiser: i am planning on making a start by adding one for `remove` but it may need some time. the thing is I would like to have `remove` completed by the end of the week since the months ends
<hkaiser>
ok
<hkaiser>
let's leave the new tests for a future pr
<gonidelis[m]>
so I will probably remove it from the existing PR and create a separate one which handles a couple of algos
<gonidelis[m]>
cool
<hkaiser>
I mean why remove tests now?
<hkaiser>
as long as those are 'correct'?
<gonidelis[m]>
it does not compile
<gonidelis[m]>
the iter-sent one
<hkaiser>
but it should compile, no?
<gonidelis[m]>
for sure i am missing sth. I will try to work it out
<hkaiser>
I'll have a look too
<gonidelis[m]>
thanks
<gonidelis[m]>
is standford legion comperable to hpx?