K-ballo has quit [Quit: K-ballo]
nikunj has joined #ste||ar
nikunj has quit [Remote host closed the connection]
nikunj has joined #ste||ar
hkaiser has quit [Ping timeout: 240 seconds]
weilewei has quit [Remote host closed the connection]
jbjnr_ has quit [Ping timeout: 265 seconds]
jbjnr has joined #ste||ar
<
mdiers_>
heller: cool! We just discussing what compiler to create for different binaries. Your serialization example was very good for it.
rori has joined #ste||ar
heller has joined #ste||ar
<
heller>
mdiers_: better measure before making a final decision ;)
<
mdiers_>
heller: just needed an example where the binary code changes well ;-)
<
simbergm>
hkaiser: yt?
K-ballo has joined #ste||ar
nikunj has quit [Remote host closed the connection]
nikunj has joined #ste||ar
lsl88 has quit [Remote host closed the connection]
hkaiser has joined #ste||ar
<
hkaiser>
heller: I would like to go ahead withthe serialization module as is for now
<
hkaiser>
I need to tend to too many other things and would like to get thi soff my plate asap
<
heller>
hkaiser: ok
<
heller>
hkaiser: I'll have a look
<
hkaiser>
heller: I'll clean up the remaining ci problems today
<
hkaiser>
not much left, I think
<
heller>
clang-format related, as it seems
<
hkaiser>
yah, just needs one last formatting pass, I will do that
<
heller>
why did you choose to externalize the pointer tracking?
<
hkaiser>
why not? it's the same thing as credit splitting
<
hkaiser>
special handlin gof certain types
<
hkaiser>
heller: but thanks for helping with this!
<
heller>
it is different as it is one core functionality
<
heller>
might add a tiny bit of overhead ;)
<
hkaiser>
is it now?
<
heller>
did you measure it?
<
hkaiser>
heller: I have not
<
hkaiser>
feel free
<
hkaiser>
with your solution any overhead will go away
<
heller>
hkaiser: I am not sure if you split during serialization is correct
<
hkaiser>
heller: sure, I have not done a thorough analysis yet, that's on my todo list
<
hkaiser>
first was to get everything compile again
<
hkaiser>
heller: I'd appreciate a second pair of eyes
<
heller>
hkaiser: It'll probably work for our internal usage, might need some adjustment for the component checkpointing, I think
<
hkaiser>
well, the component check pointing will have its own logic, I think
<
hkaiser>
this change will enable finally fixing the checkpointing
aserio has joined #ste||ar
aserio1 has joined #ste||ar
aserio has quit [Ping timeout: 240 seconds]
aserio1 is now known as aserio
hkaiser has quit [Ping timeout: 276 seconds]
weilewei has joined #ste||ar
hkaiser has joined #ste||ar
aserio1 has joined #ste||ar
rtohid has joined #ste||ar
aserio has quit [Ping timeout: 245 seconds]
aserio has joined #ste||ar
aserio1 has quit [Ping timeout: 246 seconds]
david_pfander has joined #ste||ar
david_pfander has quit [Remote host closed the connection]
david_pfander has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
david_pfander has quit [Quit: david_pfander]
hkaiser has joined #ste||ar
hkaiser has quit [Client Quit]
hkaiser has joined #ste||ar
rori has quit [Quit: bye]
aserio has quit [Ping timeout: 245 seconds]
<
heller>
hkaiser: I think I know how to handle it properly
<
heller>
Without breaking the tests or preinstering everything for every archive
aserio has joined #ste||ar
<
hkaiser>
heller: ok, wait a sec I have a force push incomming
<
hkaiser>
heller: done
<
hkaiser>
simbergm: yt?
<
simbergm>
hkaiser: here
<
hkaiser>
simbergm: what verison of clang-format do we use on circleci?
<
simbergm>
should be 8 now
<
hkaiser>
hmmm, I'm using 8 here and circle is telling me that the formatting is not right
<
hkaiser>
simbergm: not sure what I can do
david_pfander has joined #ste||ar
<
simbergm>
hkaiser: :(
<
simbergm>
we did have the case of clang-format not being idempotent
<
simbergm>
does applying it twice change anything?
<
simbergm>
maybe we should make the check print the diff as well
<
simbergm>
which branch is this btw? let's see if my clang-format does the same as yours
<
hkaiser>
the module_serialization branch
<
hkaiser>
yah, printing the diff might help
<
simbergm>
where do you see circleci complaining?
<
hkaiser>
sec, it was yesterday
<
simbergm>
I see a bunch of cancelled builds and the latest one hasn't finished that step yet
david_pfander has quit [Ping timeout: 245 seconds]
<
hkaiser>
this is the latest one
<
simbergm>
is your branch rebased on latest master?
<
simbergm>
me applying clang-format locally gives me the same list of modified files
<
hkaiser>
hmm, strange
<
hkaiser>
my clang-format -version says: clang-format version 8.0.0 (tags/RELEASE_800/final)
<
simbergm>
module_datastructures is not on latest master
<
simbergm>
there's something odd
<
simbergm>
applying clang-format on master gives me no modified files
<
simbergm>
indeed, strange
<
simbergm>
clang-format version 8.0.0-3~ubuntu18.04.1 (tags/RELEASE_800/final)
<
simbergm>
do you have docker set up?
<
simbergm>
could you try the clang-format in our testing image?
<
simbergm>
it's a lot of compatibility headers as well :/
<
simbergm>
are you sure you're applying it to all the files in the libs directory?
<
simbergm>
I gtg, but I see something odd with the ordering of includes (that's all that has changed it looks like)
<
simbergm>
I'll look later
<
hkaiser>
simbergm: ok, thank
aserio has quit [Ping timeout: 264 seconds]
aserio has joined #ste||ar
<
hkaiser>
simbergm: I formatted things in my WSL environment, let's see
weilewei has quit [Remote host closed the connection]
quaz0r has quit [Ping timeout: 276 seconds]
quaz0r has joined #ste||ar
<
K-ballo>
hkaiser: ping
aserio has quit [Quit: aserio]
aserio has joined #ste||ar
akheir has joined #ste||ar
hkaiser has quit [Ping timeout: 250 seconds]
hkaiser has joined #ste||ar
<
hkaiser>
K-ballo: here now
<
K-ballo>
hkaiser: see pm
aserio has quit [Quit: aserio]
nikunj has quit [Ping timeout: 240 seconds]
rtohid has quit [Quit: Konversation terminated!]
<
simbergm>
hkaiser: reformatting your branch now gives me just a couple of lines that are wrapped differently, let's see what circleci says
<
hkaiser>
simbergm: ok, thanks
nikunj has joined #ste||ar
nikunj has quit [Remote host closed the connection]
nikunj has joined #ste||ar