Yorlik has quit [Read error: Connection reset by peer]
jaafar has joined #ste||ar
<weilewei>
zao I finally remembered that the reason you are seeing runtime error is that you need to add hpx_setup_target(main_dca), which I had not pushed to my branch yet
weilewei has quit [Remote host closed the connection]
<zao>
That's the problem. It still doesn't do any form of wrapping, with or without hpx_main.hpp included in main_dca.cpp
<zao>
Something's hecked up here.
K-ballo has joined #ste||ar
nikunj has joined #ste||ar
<heller>
jbjnr_: see pm please
<nikunj>
hkaiser: yt?
Yorlik has joined #ste||ar
david_pfander has joined #ste||ar
<heller>
clang just iced me :/
<heller>
hkaiser: we should really try to seperate the changes from the reformatting. I would like to suggest that if we touch a file, we first reformat it, commit it, and then perform the change
<heller>
that way, we can select the commit and see the change immediately instead of trying to figure out what the gist of the change was
david_pfander has quit [Quit: david_pfander]
<hkaiser>
heller: I agree - and sorry for not doing it
<hkaiser>
I had to rebase and consolidate everything more than once which caused the mess
<heller>
not talking about the serialization stuff btw ;)
<hkaiser>
its difficult to go back, however - without redoing everything
<heller>
the performance regression is what struck me
<heller>
hmm
<heller>
not sure
<heller>
put the changes in a patch
<hkaiser>
yah, I agree as well - I can go back and redo that
<heller>
revert to master
<heller>
apply the formatting
<hkaiser>
will do
<heller>
commit
<heller>
apply the patch
<heller>
commit again
<heller>
that should do the trick
<hkaiser>
heller: better now?
<heller>
hkaiser: thanks!
<heller>
hkaiser: so the regression happened when 128 bit atomics where present?
<hkaiser>
yes, essentially always
<hkaiser>
queue is 20slower than deque (in that particular usecase
<hkaiser>
20 percent
<heller>
well, the PR still uses the queue with no 128 bit atomics
<hkaiser>
sure, deque requires 128bit atomics
<hkaiser>
nothing we can do there
<heller>
-latomic ...
<heller>
no?
<hkaiser>
-latomic has no 128bit implementation on some platforms - don't ask why
<hkaiser>
that was why we introduced all of this, see #3996
<heller>
ok
<heller>
stupid ..
<hkaiser>
indeed
<heller>
in any case: How did #3996 introduce a performance regression then?
<heller>
and why is this fixing it?
<heller>
I can see how it mit generally improve the situation though