nikunj has quit [Remote host closed the connection]
hkaiser has quit [Quit: bye]
nikunj has joined #ste||ar
<K-ballo>
is Rebecca here?
<simbergm>
diehlpk_work: in general yes, but if it's more hassle and I can't help much I can skip it
<simbergm>
if I'm more useful later I'll join then instead
<simbergm>
K-ballo: I don't think so, she went by USTOBRE at some point
<simbergm>
jbjnr: I think your sliding_semaphore version of the future_overhead benchmark needs fixing
<simbergm>
it's not guaranteed to wait for all futures
<simbergm>
not sure if you want to keep it since you have the limiting executor doing pretty much the same thing
<simbergm>
I think you'd need two counters to do it correctly (latch and sliding_semaphore or just two atomic counters)
rori has joined #ste||ar
<simbergm>
heller, jbjnr: should we have a call for the cscs course in time this time so we know what still needs to be done? like next week?
hkaiser has joined #ste||ar
<heller>
simbergm: that would be good
<hkaiser>
simbergm: what do you think about #4068? I know its a hack, so any better ideas would be welcome
<simbergm>
heller: good
<simbergm>
hkaiser: either changing the ifdef (if that works) or boost::spinlock are both better I think
<hkaiser>
simbergm: I ran into similar missing #includes for the collectives stuff
<hkaiser>
not only spinlock
<hkaiser>
this will be a problem for all modules that have source files and that depend on the remaining 'runtime-blob'
<simbergm>
mmh, that's why I'd like to move the massive runtime-blob into a module already now
<hkaiser>
nod
<simbergm>
it interferes with everything though
<simbergm>
especially the cmake branch
<hkaiser>
right
<hkaiser>
I think my hack provides a simple enough intermediate solution
<simbergm>
adding a special-case target_include_directories like that is I think a good, minimally hacky solution
<hkaiser>
that does not interfere with anything
<simbergm>
yeah, definitely
<hkaiser>
we could enable it on a module by module bases, but then we would have to go back and touch on all related modules later on
<simbergm>
so yeah, sorry if I was being dismissive, I think it's a good solution where we can't do anything else yet; for #4068 I hope we can avoid it
<hkaiser>
not sure this is a good idea
<simbergm>
hold on, you didn't have to do this for collectives, right?
<hkaiser>
yes, I needed it there
<simbergm>
link?
<hkaiser>
well, I'm talking about #4068, what other options do you have in mind?
<simbergm>
let's see, circleci should tell us soon
<hkaiser>
we would have seen that already as our cyclicity checking relies on real header files, while the cmake dependencies are maintained by hand indepently
<hkaiser>
the dependency on concurrency we need to specify because of the runtime-blob that is pulled in by logging
aserio1 has joined #ste||ar
<simbergm>
if logging pulls in the runtime blob I've done something wrong
<simbergm>
it shouldn't be doing that
<hkaiser>
well, apparently it does, at least on mac
<hkaiser>
compiling logging.cpp was looking for a header from hpx/concurrency
<hkaiser>
and from hpx/timing
aserio1 is now known as aserio
<simbergm>
right, it pulls in concurrency but not the whole runtime blob, and only on non-windows/linux
<simbergm>
hence the suggestion to use boost spinlock instead
weilewei has quit [Remote host closed the connection]
<heller>
hmm, wei is gone instead
<heller>
already
aserio has quit [Ping timeout: 276 seconds]
weilewei has joined #ste||ar
aserio has joined #ste||ar
<hkaiser>
heller, simberg: just removing transfer_action gives us a 10% compilation speedup of the main core library (including linking) on my machine (74s vs 65s)
<hkaiser>
there is a lot more code that could be removed if networking is disabled
<heller>
hkaiser: try the unit tests or examples or so
<hkaiser>
sure
<heller>
I suspect that this will give the real boost
<diehlpk_work>
heller, git log will give me the names of the authors of each file
<diehlpk_work>
How will I get the names to each of the cpp files and hpp files?
<diehlpk_work>
And all names even once
<diehlpk_work>
If you have any idea to add the names from the git log to the files of octotiger, I would be happy to get the script doing this?
<heller>
I don't have such a script
<heller>
You initiated the change
<heller>
BTW, changing licenses in the aftermath theoretically requires the consent of all authors. not that I'm objecting in general, just saying...
aserio has quit [Ping timeout: 250 seconds]
hkaiser has quit [Quit: bye]
<zao>
I (jokingly) object!
<zao>
Jokes aside, I'm fine with whatever you would want to do with my few contributions.
<heller>
zao: it's about octotiger, not hpx itself
<zao>
Oh. Carry on then :)
aserio has joined #ste||ar
aserio has quit [Quit: aserio]
hkaiser has joined #ste||ar
weilewei has quit [Remote host closed the connection]