hkaiser changed the topic of #ste||ar to: STE||AR: Systems Technology, Emergent Parallelism, and Algorithm Research | stellar.cct.lsu.edu | HPX: A cure for performance impaired parallel applications | github.com/STEllAR-GROUP/hpx | Buildbot: http://rostam.cct.lsu.edu/ | Log: http://irclog.cct.lsu.edu/ | GSoC2018: https://wp.me/p4pxJf-k1
diehlpk has joined #ste||ar
<github> [hpx] hkaiser pushed 1 new commit to master: https://git.io/fNfn7
<github> hpx/master 2ad0485 Hartmut Kaiser: Fixing cmake in SetupTarget...
hkaiser has quit [Quit: bye]
nikunj has joined #ste||ar
aserio has joined #ste||ar
aserio has quit [Quit: aserio]
diehlpk has quit [Ping timeout: 256 seconds]
mbremer has joined #ste||ar
mbremer has quit [Client Quit]
K-ballo has quit [Quit: K-ballo]
jaafar has quit [Ping timeout: 240 seconds]
jakub_golinowski has joined #ste||ar
<jbjnr> heller: sorry about last night. got home later than expected. Did you have a call anyway?
<heller> jbjnr: yeah, the connection was very bad though
<heller> we didn't get far
<heller> we decided to have another call tomorrow morning
<jbjnr> ok
<heller> are you available tomorrow morning? something around 8 to 11 or so?
david_pfander has joined #ste||ar
jakub_golinowski has quit [Ping timeout: 244 seconds]
jakub_golinowski has joined #ste||ar
<jbjnr> heller: yes. I'm available
nikunj97 has joined #ste||ar
FjordPrefect has quit [Ping timeout: 245 seconds]
itachi_uchiha_ has quit [Ping timeout: 245 seconds]
jakub_golinowski has quit [Ping timeout: 256 seconds]
jakub_golinowski has joined #ste||ar
jakub_golinowski has quit [Ping timeout: 276 seconds]
jakub_golinowski has joined #ste||ar
FjordPrefect has joined #ste||ar
itachi_uchiha_ has joined #ste||ar
jakub_golinowski has quit [Ping timeout: 240 seconds]
jakub_golinowski has joined #ste||ar
nikunj has quit [Quit: Leaving]
jakub_golinowski has quit [Ping timeout: 240 seconds]
jakub_golinowski has joined #ste||ar
nikunj1997 has joined #ste||ar
nikunj97 has quit [Ping timeout: 248 seconds]
<nikunj1997> zao: yt?
<zao> Hi!
<zao> Back at work, trying to remember how everything works :)
<nikunj1997> Hi!
<nikunj1997> I needed a bit of help
<nikunj1997> Can you build this HPX branch: https://github.com/STEllAR-GROUP/hpx/pull/3371
<nikunj1997> and then build phylanx from this branch https://github.com/STEllAR-GROUP/phylanx/pull/519 (make HPX_DIR the one you are building above)
<M-ms> jakub_golinowski: yt?
<zao> Phylanx? Oh gods.
<zao> nikunj1997: On what platform?
<nikunj1997> linux
<nikunj1997> there were some problems yesterday with hpx applications using my implementation
<nikunj1997> So I have tried to rectify them in those 2 pr. I want you to check if they work now.
<zao> Can't promise anything, trying to work.
<nikunj1997> ok
<github> [hpx] StellarBot pushed 1 new commit to gh-pages: https://git.io/fNfVe
<github> hpx/gh-pages e01417a StellarBot: Updating docs
<jakub_golinowski> M-ms, here
<M-ms> hey, just wanted to let you know that your webcam example runs nicely now for me as well (it was the location of my build folder and missing gtk libraries)
<M-ms> will try to run your test script tonight
<M-ms> and I think we can skip our call today unless you have some pressing questions
<github> [hpx] msimberg opened pull request #3372: WIP: Fix some more c++11 build problems (master...fix-c++11) https://git.io/fNfws
<zao> `Resolving deltas: 18% (148849/820917)`
<zao> Git and Lustre don't mix :(
<nikunj1997> :/
<zao> Lunch!
<jakub_golinowski> M-ms, great that the webcam example runs properly! I also think that the call is no necessary today, since I still have tasks pending from the call on Friday
<zao> Bah, built with the wrong toolchain.
<nikunj1997> which one did you use?
<zao> Was going to use our intel/2018a toolchain but accidentally forgot to set the environment, so it found the GCC 6.4.0 toolchain it's built on.
<zao> Interestingly enough, phylanx with the same modules finds the system GCC 5.4.0.
<nikunj1997> would it matter?
<zao> Well, mismatching HPX and phylanx's compilers and runtimes would be bad from my side.
anushi has joined #ste||ar
nikunj97 has joined #ste||ar
nikunj1997 has quit [Ping timeout: 244 seconds]
<zao> Oh joy, HPX doesn't build with Intel...
<nikunj97> what does it say?
<zao> Same old exception_ptr crud. I forget how I solved it last time :(
<nikunj97> oh
<zao> Rebuilding with foss/2017b instead.
<nikunj97> ok
<zao> nikunj97: Eugh, I forgot how silly their HPX_DIR thing was, needing the full path into lib/cmake/HPX.
<zao> CMake Error at /pfs/software/eb/amd64_ubuntu1604_bdw/software/Compiler/GCCcore/6.4.0/CMake/3.10.2/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
<zao> Could NOT find Threads (missing: Threads_FOUND)
<zao> Don't make me read documentation :)
<zao> Blaze, eugh.
<nikunj97> try removing cmake cache and see if it works
<nikunj97> I faced the same situation yesterday. That seemed to do it for me
<zao> No change.
<nikunj97> oh
<nikunj97> it is related to blaze
<nikunj97> zao: do you have blaze installed?
<zao> No. I don't have anything that's not needed for HPX.
<zao> Nor is there any documentation for this Phylanx thing.
<nikunj97> oh that's why
<zao> As bad as it was last time I was tricked into building it... <_<
<nikunj97> also `sudo apt install pybind11-dev`
<zao> I'm at work, I can't install random system packages.
<nikunj97> oh, don't then. Try running it later
heller___ has joined #ste||ar
heller has quit [Read error: Connection reset by peer]
<zao> So this is using what, Python 2 or 3?
<nikunj97> I'm not sure
<nikunj97> I did not checkout the code
<jakub_golinowski> M-ms, FYI the there is a response to the PR from OpenCV
<zao> Might be both, time will tell.
hkaiser has joined #ste||ar
jakub_golinowski has quit [Quit: Ex-Chat]
jakub_golinowski has joined #ste||ar
K-ballo has joined #ste||ar
<nikunj97> hkaiser: yt?
<hkaiser> here
<nikunj97> So I added a way to propagate the linker flags
<nikunj97> This way we do not need to worry about the hpx application
<hkaiser> nod, I have added two small comments
<nikunj97> If HPX was build using dynamic hpx main then things will work similar to my implementation else things will revert back to original one
<nikunj97> yes, I've updated it and added another commit
Anushi1998 has joined #ste||ar
<hkaiser> nice, thanks
<nikunj97> hkaiser: again sorry for not noticing something like this. I should have guessed this behavior
<hkaiser> no worries
<hkaiser> your work produces nice results!
<nikunj97> thank you :)
<zao> nikunj97: Do you have any specific HPX flag one should use when building it?
<zao> (didn't read any documentation, if it exists :P )
<nikunj97> no, it defaults to on
<nikunj97> so you can simply build like you used to
<nikunj97> and things will work out of the box
<hkaiser> nikunj97: would you mind updating your docs to reflect your recent changes?
anushi has quit [Ping timeout: 240 seconds]
<nikunj97> hkaiser: I think the one for hpx_main is enough. If you want me to add docs specific to this hpx aplication and the flags and implementation stuff, then I can add more
<hkaiser> I'll read it again
<zao> nikunj97: I have reason to believe that your wrapping of main may interfere with the CMake tests of phylanx.
<hkaiser> zao: they do
<nikunj97> ok, I can always add to the docs. But I felt adding all the implementation for user will bloat our doc. This is because the user is more concerned about using hpx functionality from main instead of how we bring that functionality to him in that section.
<nikunj97> I can add the implementation related stuff in another section where curious readers can read it
<nikunj97> zao: I can't see libhpx_wrap.a in there
<nikunj97> did you build my hpx branch?
<zao> Note that this is during CMake trying to find LAPACK. Not any build process of actual Phylanx programs.
anushi has joined #ste||ar
<zao> There is no mention of anything libhpx_wrap[d].a in the HPXConfig.cmake and friends.
<zao> Just your -wrap=... bit.
<zao> ../inst-nik-hpx-debug/lib/cmake/HPX/HPX_GeneratePackage.cmake: set(HPX_PKG_LIBRARIES "\${libdir}/libhpx_wrap.a ${HPX_PKG_LIBRARIES}")
<zao> ../inst-nik-hpx-debug/lib/cmake/HPX/HPX_GeneratePackage.cmake: set(HPX_PKG_DEBUG_LIBRARIES "\${libdir}/libhpx_wrapd.a ${HPX_PKG_DEBUG_LIBRARIES}")
<zao> Those are there of course, but that doesn't help when the compiler flags are _universally_ used for anything built.
<zao> `HPXConfig.cmake: set(CMAKE_EXE_LINKER_FLAGS`
<zao> This is going to affect _everyone_ and their dog.
<zao> While the rest just affects HPX targets, like HPX_SetupTarget assumedly does.
<zao> Phylanx cannot be configured at all here.
<nikunj97> aah yes
<nikunj97> it seemed to work for me for some reason over here. But yes this error is due to the -wrap symbol
<zao> Anyway, happy to help.
<nikunj97> Let me see what I can do
<zao> You made me write pybind11 and Blaze recipes for EasyBuild, was educational :)
<M-ms> jakub_golinowski: hrm, interesting
<M-ms> I think he might be skeptical because it's not clear what including hpx_main does
<hkaiser> zao: Alireza might be interested in seeing those
<M-ms> jbjnr: might be interesting to you as well: https://github.com/opencv/opencv/pull/11897
<jakub_golinowski> M-ms, well I mean it seems they are not listening very carefully and are focuesd mostly no having to include anything to all possible apps
<hkaiser> M-ms: all pycicle links go to a 404
<zao> (rather straightforward, trickiest bit was -DPYBIND11_TEST=OFF because we don't have pytest)
<M-ms> we really want the user to be including hpx_main (or hpx_init or hpx_start...) so that they are free to choose how to initialize hpx
<M-ms> hkaiser: yep, sorry, I saw your message
<hkaiser> ok
<M-ms> I think I found the issue, awaiting approval from jbjnr https://github.com/biddisco/pycicle/pull/33
<M-ms> thanks for reporting
<hkaiser> M-ms: thanks for running pycicle!
<nikunj97> hkaiser: HPX provides with the include directory and library directory to link with, right?
<hkaiser> nikunj97: it exports targets that have the include dir etc. attached, yes
<nikunj97> does it export any linker/cxx flags?
<hkaiser> not sure
<nikunj97> adding my linker flags to CMAKE_EXE_LINKER_FLAGS will break things if cxx test files are ran after it
<nikunj97> it somehow did not do it my laptop
<nikunj97> but it is apparent from zao's result
<hkaiser> k
* zao implements fika
<jbjnr> M-ms: jakub_golinowski it seems that Sam and Ben must be working for OpenCV now. We will not use it if we have to add a #include to our code!
<hkaiser> jbjnr: who are Sam and Ben?
<jbjnr> in other projects that do this kind of thing. I have modified the CMake in such a way that when OPENCV_WITH_HPX is enabled, an extra include is pulled in to the library such that the user does not see it. However, with OpenCV this would probably not work because we cannot make int main() run on an hpx thread since many things will use blocking OS calls
nikunj1997 has joined #ste||ar
<hkaiser> we can use the global object trick
<jbjnr> hkaiser: Sam and Ben are the CSCS guys who refuse to use HPX because it introduces dependencies they don't want, so they are writing their own task based runtime scheduler etc.
mcopik has joined #ste||ar
<hkaiser> jbjnr: ahh! makes perfect sense! I like those guys. ;-)
<jbjnr> You don't.
<hkaiser> heh
<hkaiser> idiots
<jbjnr> I used to. But not any more.
<jbjnr> No. They laim that their use case is just too simple to be worth a full HPX and they just need a few async cals here and there.
<hkaiser> shrug, we should save our energy to work with those who are interested in working with us
<jbjnr> ^claim
<hkaiser> jbjnr: yah sure, the usual nonesense
<jbjnr> hkaiser: didn't you notice yet? nobody is interested in working with us
<hkaiser> jbjnr: not true
<hkaiser> stop being depressed
<hkaiser> everybody loves you!
<jbjnr> <sigh>
nikunj97 has quit [Ping timeout: 256 seconds]
<jakub_golinowski> jbjnr, about the OpenCV: I will write you a howto for the mandelbrot benchmark in a minute
<jbjnr> thanks jakub_golinowski
<jbjnr> M-ms: thanks. merged one pycicle PR and ... hkaiser I've restarted pycicle, so links should be fixed.
<jakub_golinowski> M-ms, jbjnr - I think apart from making the OpenCV ppl understand what hpx_main.hpp is doing and why we want the backend assuming runtime running I should also boost the start-stop backend to the suspend-resume backend with global object and at the same time tune the perf
<jbjnr> jakub_golinowski: would it help if I comment on the PR?
<jakub_golinowski> Then they see suspend-resume working OK and maybe will be more open to listen why we STILL want the backend assuming runtime started
<M-ms> jbjnr: thanks for merging
<jbjnr> not sure I understand this comment " I should also boost the start-stop backend to the suspend-resume backend with global object and at the same time tune the perf"
<M-ms> a user-started runtime is really the main use-case for the hpx backend
<jakub_golinowski> jbjnr, my understanding is that OpenCV ppl are a little bit not willing to understand why we want the user-started runtime backend versio
<jakub_golinowski> and now after two posts in which I try to explain it they do not answer that at all but only ask about performance
<jakub_golinowski> So I assume that the only wayt to make them listen now is to show them we can address their problems
<M-ms> jakub_golinowski: although interesting I wouldn't focus too much on it because it will always be a secondary use case (and they have their existing backends for completely hiding the backend from the user)
<jbjnr> correct.
<jakub_golinowski> M-ms, jbjnr: hmmm
<jakub_golinowski> So maybe better to start with investigating why user-started hpx is not as good as openmp and tbb
<jbjnr> yes
<jakub_golinowski> ok, so let me relaunch the mandelbrot benchmark and write the howto
<jbjnr> thanks
<M-ms> jakub_golinowski: it might also be that once they understand what is happening they'll be more likely to accept it
<nikunj1997> Now I'm getting the pthread error as well :/
<jbjnr> I will add a comment to the PR anyway
hkaiser has quit [Quit: bye]
anushi has quit [Ping timeout: 240 seconds]
quaz0r has quit [Ping timeout: 240 seconds]
<nikunj1997> zao: yt?
anushi has joined #ste||ar
<jbjnr> jakub_golinowski: M-ms https://github.com/opencv/opencv/pull/11897#issuecomment-403476524 Hoipe this comment does not make matters worse
<M-ms> jbjnr: that's a nice answer, hope they're willing to reconsider
<jakub_golinowski> jbjnr, thank you very much!
<jakub_golinowski> But I realized it would be nice to pull the build paths to the variables so just need a minute
<jbjnr> lol
<nikunj1997> are we planning any HPX related session this year at cppcon?
anushi has quit [Ping timeout: 240 seconds]
<zao> nikunj1997: Hi!
<nikunj1997> zao: I realized why it wouldn't find threads
anushi has joined #ste||ar
<nikunj1997> if you could open up the cmakelists of phylanx
<nikunj1997> you will see that phylanx_setup_hpx is added first
<nikunj1997> which imports the CMAKE_EXE_LINKER_FLAGS
<nikunj1997> which breaks the blaze system
<zao> Sneaky :)
<nikunj1997> that's why it reported those errors
<nikunj1997> if you however put phylanx_setup_hpx after other setups, things run smoothly
<zao> jbjnr: I tried using Windows's built-in thread pools the other day. Found out the fun way that if you allocate up to a gigabyte per task, having 80 concurrent tasks is not a good thing :D ^^
<zao> If only a good task system existed :)
<nikunj1997> zao: could you please change the order and add the `phylanx_setup_hpx` to https://github.com/STEllAR-GROUP/phylanx/blob/master/CMakeLists.txt#L134
<nikunj1997> and then try to build phylanx
<zao> Gets past that bit, failing miserably at finding my Blaze right now.
<nikunj1997> do you have blaze installed?
<zao> Yes, and it doesn't care if I specify -Dblaze_DIR=$EBROOTBLAZE
<zao> I guess I need to point down into it's share.
<zao> Never really understood software that requires the cmake directory, instead of just pointing out a root.
<nikunj1997> I have blaze installed in /usr/local (I didn't care less building it again)
<nikunj1997> zao: :D
<jakub_golinowski> jbjnr, yt?
<jbjnr> zao yes. 80GB. very entertaining. try more!
<jbjnr> jakub_golinowski: here
<zao> jbjnr: Would've been fine at work, but it was on my poor 32G machine at home :D
<jakub_golinowski> jbjnr, I thik I am finished with the how to
Anushi1998 has quit [Ping timeout: 240 seconds]
<jakub_golinowski> I also pushed the changes to the repo
<nikunj1997> zao: what are the specs of your test bench?
<zao> Which one?
<nikunj1997> the best one :p
<zao> The one with the debian container is a Ryzen 1700 with 16G of memory.
<nikunj1997> nice!
<zao> Machine at work is a boring login node with a Broadwell and 128G of memory, or a Skylake-SP with 192G.
Anushi1998 has joined #ste||ar
<zao> Anyway, managed to configure phylanx eventually, and it's building.
<zao> (not done)
<nikunj1997> good to hear :)
<nikunj1997> I hope it works
<zao> Failure!
<nikunj1997> oh :/
<zao> `/hpc2n/eb/software/MPI/GCC/6.4.0-2.28/OpenMPI/2.1.1/pybind11/2.2.3-Python-3.6.3/include/pybind11/detail/common.h:111:20: fatal error: Python.h: No such file or directory`
<nikunj1997> lol
<nikunj1997> do you have pybind installed?
<zao> Yes, otherwise I wouldn't have gotten this far.
<jbjnr> jakub_golinowski: which branch in your opencv clone should I use? jakub/hpx_backend_stable or master?
<zao> I do wonder why I don't have Python loaded tho.
<zao> Ah, I suck :P
<nikunj1997> this error is not linked with my implementation (as far as I see it)
<zao> Indeed.
<zao> (I had Python as a build dependency, not a proper dependency)
<jbjnr> or just hpx_backend (that's the one in the R, so I will try it first)
<jbjnr> ^PR
<jakub_golinowski> jbjnr, use hpx_backend_stable
<jakub_golinowski> jbjnr, actually I also have a script for building opencv with all different backends
<jakub_golinowski> jbjnr, you can use it to build all the backends in the "schme" that is accepted by the run_opencv_mandelbrot script
<jbjnr> ok. thanks. I will first try hpx backend alone then once I am sure it works, try others etc
Anushi1998 has quit [Ping timeout: 240 seconds]
<jbjnr> but probably not tonight. might take me a day or three
Anushi1998 has joined #ste||ar
<zao> nikunj1997: Builds fine.
<nikunj1997> :)
<zao> Well, there might be warnings, but there's so much noise I can't tell.
<zao> Testbed all fails, so that's something.
<nikunj1997> try tests
<nikunj1997> does all the tests fail?
<zao> Ah, it had apparently not built all of them.
<zao> Have I ever mentioned how much I hate CMake builds that have optional targets and poor dependencies?
<nikunj1997> noted
<jbjnr> Don't hold yourself back zao - feel free to vent
<zao> CMake, the least horrible build system generator.
<zao> In all meanings of the phrase :P
anushi has quit [Read error: Connection reset by peer]
anushi has joined #ste||ar
<zao> I have no idea why/how these fail.
<nikunj1997> these are python files. I have no clue as well
<zao> Seems to be all in the Pythong bindings.
<zao> As to whether your stuff is ruining it, heaven knows.
<zao> nikunj1997: How does your stuff interact with a HPX that's a Python module?
<nikunj1997> I haven't considered it as of now
<nikunj1997> So I'm yet to understand that part
<nikunj1997> I thought it was all c++
<nikunj1997> I don't have the slightest idea how phylanx work
<nikunj1997> zao: would you mind building phylanx with an older HPX commit build?
<nikunj1997> I want to know if it's my code that's ruining everything
anushi has quit [Ping timeout: 264 seconds]
<zao> Could try.
<nikunj1997> thank you
<zao> Does the tests work for you?
<nikunj1997> no I had the same result
Anushi1998 has quit [Ping timeout: 264 seconds]
Anushi1998 has joined #ste||ar
jaafar has joined #ste||ar
anushi has joined #ste||ar
<nikunj1997> zao: I tried with an older commit, situation seemed to be exactly the same for me
<nikunj1997> did it change for you?
<zao> 15 tests failed
<nikunj1997> In my case there were 16
<nikunj1997> 20-27,73,119-126
<nikunj1997> seems like we need to configure something to run them properly
<zao> Same tests in both runs here.
<zao> Or they may be permanently broken.
<zao> Heaven knows :D
<nikunj1997> yeah. I'll wait for hkaiser to help us out here
<zao> Wait, disregard this.
<zao> I accidentally used the wrong HPX.
<nikunj1997> which one did you use?
galabc has joined #ste||ar
<zao> yours again.
<nikunj1997> oh
quaz0r has joined #ste||ar
<nikunj1997> why does my pc run slow after it has built everything :/
<zao> Probably have forced every single thing out of memory and into swap.
<nikunj1997> I saw results of make -j5 from htop. Never used more than 8-9Gb of memory. I have a 16 GB config
<nikunj1997> Also laptop seems to run fine while building (unless it's a test build, then it runs slow)
<zao> Linking tests is the killer, mostly.
<nikunj1997> zao: how long does it take normally to build hpx on your machine?
<zao> Don't remember.
<zao> 20min?
<zao> Haven't touched the build machine at home in ages, because of other interests.
<zao> `creating /afs/hpc2n.umu.se/home/l/lars/.local/lib/python3.6/site-packages/phylanx-0.0.1-py3.6-linux-x86_64.egg`
<nikunj1997> ok
<zao> FFS. Why does it do this when I explicitly specify an install path
<zao> Goddammit.
<zao> How hecking hard can it be to make builds that don't put shit in places it doesn't belong?
<zao> (everyone, not just this god-forgotten package)
<zao> nikunj1997: Heh, HPX master fails harder than you.
<zao> nikunj1997: For the Python tests, proper HPX fails the same way.
<nikunj1997> HPX master latest commit?
<zao> For other tests:
<zao> terminate called after throwing an instance of 'std::invalid_argument'
<zao> what(): hpx::resource::get_partitioner() can be called only after the resource partitioner has been allowed to parse the command line options.
<zao> Base command is "/pfs/nobackup/home/l/lars/stellar/build-stellar-nik-phylanx-debug/bin/primitive_counter_test --hpx:threads=1 --hpx:localities=1"
<zao> Executing command: /pfs/nobackup/home/l/lars/stellar/build-stellar-nik-phylanx-debug/bin/primitive_counter_test --hpx:threads=1 --hpx:localities=1 --hpx:node=0
<zao> nikunj1997: Yes, from stellar-group's repo.
<nikunj1997> oh yeah, this is the mess my implementation did :/
<nikunj1997> Can you check a few commits back
<zao> Seems like HPX, as usual, doesn't work :(
<nikunj1997> that's why I asked you to try out an older commit
<zao> nikunj1997: Nope. I'm going home.
<nikunj1997> ok no problems
<zao> If you figure out a commit hash I should test, I could possibly start it tonight.
<nikunj1997> try: 849dca0c5f9fb7ea326394e54529638488a77485
<nikunj1997> zao: don't try the above one. Try this: 6bda03a990671b3be9e6697384e8a62c4f47f6cc
Anushi1998 has quit [Quit: Bye]
mcopik has quit [Ping timeout: 240 seconds]
hkaiser has joined #ste||ar
quaz0r has quit [Ping timeout: 260 seconds]
jbjnr has quit [Ping timeout: 240 seconds]
anushi has quit [Ping timeout: 268 seconds]
jakub_golinowski has quit [Ping timeout: 264 seconds]
anushi has joined #ste||ar
mcopik has joined #ste||ar
quaz0r has joined #ste||ar
jakub_golinowski has joined #ste||ar
<nikunj1997> hkaiser, yt?
david_pfander has quit [Ping timeout: 256 seconds]
quaz0r has quit [Ping timeout: 264 seconds]
<hkaiser> nikunj1997: here
<nikunj1997> hkaiser: a bit of help with these failing tests: https://gist.github.com/zao/82965bdd4189c9652b460b89badbc3d6
<nikunj1997> these are python tests.
<nikunj1997> c++ HPX seems to run just fine
<hkaiser> hmm
<hkaiser> what platform is that?
<nikunj1997> linux
<nikunj1997> ubuntu 18.04lts
<hkaiser> probably a LD_LIBRARY_PATH issue
<hkaiser> not sure what's missung
<nikunj1997> ohk
<nikunj1997> do they seem to be linked with linking errors?
<nikunj1997> from my implementation
<hkaiser> python doesn't locate the plugins, which could be caused by dependent modules not being found
<hkaiser> no, those are most likely unrelated
<nikunj1997> ok, then I think my implementation should work now
<nikunj1997> hkaiser: could you try running it on your environment just to be double sure?
<hkaiser> nikunj1997: I did get it to work before, but you have changed things
<nikunj1997> oh! I didn't know that
<nikunj1997> what should we do then?
<hkaiser> nikunj1997: I mostly corrected the wrong setuptarget cmake expression
<hkaiser> nikunj1997: the rest on that branch is unrelated to your stuff
<nikunj1997> hkaiser, I also added a pr in phylanx that reverted changes
<nikunj1997> phylanx will now run out of the box
<nikunj1997> without adding hpx specific flags
<hkaiser> yes, but that one breaks things
<hkaiser> nikunj1997: but that could be because the HPX changes have not been merged yet
<nikunj1997> yes, because it relies on the pr sent in hpx
<nikunj1997> hkaiser, yes
<nikunj1997> I just shared the test results of that branch
<nikunj1997> where python seemed to fail
<hkaiser> nikunj1997: why don't we need the setuptarget changes anymore?
<nikunj1997> because I export the linker flags to CMAKE_EXE_LINKER_FLAGS
<hkaiser> but that should be done for executables only, no?
<hkaiser> ahh, right
<nikunj1997> it's for executable only option
<hkaiser> yes
<nikunj1997> so it will be taken care of as well
<hkaiser> have you changed the hpx PR so that this happens for Linux only?
<nikunj1997> yes i have
<hkaiser> good
<hkaiser> let me have a look
<nikunj1997> oh wait, there are still some places
<nikunj1997> Let me rectify them as well
<hkaiser> nikunj1997: yah, it should read if(HPX_WITH_DYNAMIC_HPX_MAIN AND ("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux")) everywhere
nikunj has joined #ste||ar
<nikunj> hkaiser: done
<hkaiser> thanks
jakub_golinowski has quit [Read error: Connection reset by peer]
<hkaiser> let's let it cycled and then we merge it
<nikunj> ok
<hkaiser> afterwards we can retrigger your Phylanx PR
<nikunj> yes
nikunj1997 has quit [Ping timeout: 264 seconds]
jakub_golinowski has joined #ste||ar
jakub_golinowski has quit [Ping timeout: 256 seconds]
nikunj97 has joined #ste||ar
nikunj has quit [Remote host closed the connection]
jakub_golinowski has joined #ste||ar
quaz0r has joined #ste||ar
jakub_golinowski has quit [Ping timeout: 244 seconds]
jakub_golinowski has joined #ste||ar
galabc has quit [Quit: Leaving]
mcopik has quit [Ping timeout: 240 seconds]
mcopik has joined #ste||ar
jakub_golinowski has quit [Read error: Connection reset by peer]
jakub_golinowski has joined #ste||ar
<nikunj97> hkaiser: seems like 1 test failed: https://github.com/STEllAR-GROUP/hpx/pull/3371
<hkaiser> yes, I retriggered that one
<nikunj97> it passed this time
<nikunj97> or no it is still running
Anushi1998 has joined #ste||ar
<nikunj97> successful
<hkaiser> nikunj97: why did you add hpx_wrap.cpp back into the source group for hpx_init (https://github.com/STEllAR-GROUP/hpx/pull/3371/files#diff-95e351a3805a1dafa85bf20b81d086e6R57)/
<hkaiser> sorry, I take this back
<hkaiser> merged
<github> [hpx] hkaiser pushed 3 new commits to master: https://git.io/fNJzJ
<github> hpx/master fa197d6 Nikunj Gupta: Fixes breaking of HPX apps
<github> hpx/master da46a78 Nikunj Gupta: Fixed errors found in review
<github> hpx/master 4de0e63 Hartmut Kaiser: Merge pull request #3371 from NK-Nikunj/fix_hpx_cmake_apps...
<nikunj97> time to check if phylanx works now
<hkaiser> nikunj97: no, hpx tests must cycle for circle to build the docker file the phylanx circle depends on
<nikunj97> ohk
<nikunj97> it will take while for it then
<hkaiser> yes
Anushi1998 has quit [Ping timeout: 240 seconds]
<jakub_golinowski> M-ms, yt?
jakub_golinowski has quit [Ping timeout: 256 seconds]
jakub_golinowski has joined #ste||ar
Anushi1998 has joined #ste||ar
hkaiser has quit [Quit: bye]
hkaiser has joined #ste||ar
mcopik has quit [Ping timeout: 256 seconds]
<parsa[[w]]> hkaiser: done
parsa[[w]] is now known as parsa[w]
<K-ballo> hkaiser: there?
<hkaiser> here
<hkaiser> K-ballo: ^^
<K-ballo> hkaiser: see pm
<hkaiser> parsa[w]: could you please ask Wei why has deleted my (Phylanx) branch ?
mbremer has joined #ste||ar
<hkaiser> nikunj97: building inspect in Phylanx repo still fails: https://circleci.com/gh/STEllAR-GROUP/phylanx/5355
<parsa[w]> hkaiser: because he uses CLion
<nikunj97> hkaiser: let me fix the inspect
<nikunj97> hkaiser: there is no artifact uploaded for the inspect
<nikunj97> oh crap it's something else
<hkaiser> parsa[w]: why does CLion close unmerged PRs?
<hkaiser> nikunj97: it's that linker error
<nikunj97> yes
<nikunj97> it linked to inspect but did not link my library
<hkaiser> he reopened it, ok
<nikunj97> hkaiser: is there a way to get verbose output for it?
<parsa[w]> hkaiser: it doesn't close unmerged PRs. it's got a terrible UI
<hkaiser> nikunj97: add VERBOSE=1 at the end of the cmake invocation
<hkaiser> cmake --build build -- -j2 tools.inspect VERBOSE=1 (here: https://github.com/NK-Nikunj/phylanx/blob/revert_to_original/.circleci/config.yml#L120)
<nikunj97> hkaiser: does phylanx has it's own linker flag which it uses to link files?
<hkaiser> nikunj97: inspect is tricky, for simplicity it links with hpx without ever needing hpx at all ;-)
<hkaiser> phylanx has no special linker flags
<jakub_golinowski> M-ms, I restructured my opencv_hpx_backend repo to allow for single-command build by introducing the root-level CMakeLists. For now it is in the branch: https://github.com/Jakub-Golinowski/opencv_hpx_backend/tree/cmake_tree in order not to confuse John when he wants to reproduce the mandelbrot benchmark. However I already tested it in reduce parameter scope on my mahcine and it worked.
<jakub_golinowski> The cmake rework was not that trivial because I also added the root-level data directory which is properly passed for both cases when there is a whole build and when there are individual builds of single apps. Also I pulled out the params BACKEND_NON_HPX and BACKEND_STARTSTOP to the top CMakeLists and apply them to all examples uniformly. However 2 examples cannot work against the HPX_STARTSTOP backend therefore I just do
<jakub_golinowski> not build them when the HPX_STARTSTOP option is set to ON. I noted some questions I had under way and did not manage to resolve to the questions gdoc. If there are any bad practices in the cmake structure I proposed pleas let me know.
<nikunj97> hkaiser: if it links with hpx then that error should not have come
<nikunj97> That error occurs when the linker flag is given but library is not linked
<hkaiser> nikunj97: I'm seeing the same problem with my phylanx branch (that is not using your phylanx fix)
<hkaiser> my branch did work with the previous hpx master, though
<hkaiser> nikunj97: inspect uses phylanx_setup_target
<nikunj97> Then how come it does not link with hpx?
<hkaiser> it sees the linker flag, but not the hpx_wrap library
<nikunj97> yes
<nikunj97> it is a weird behavior
jakub_golinowski has quit [Quit: Ex-Chat]
<hkaiser> nikunj97: ^^
<hkaiser> have you tried building inspect on your machine?
<nikunj97> hpx_wrap should be included in it
<nikunj97> it says no make targets found
<hkaiser> (needs cmake -DPHYLANX_WITH_TOOLS=On)
<nikunj97> aah that's why
<nikunj97> I'll add it right away
Anushi1998 has quit [Quit: Bye]
mbremer has quit [Quit: Page closed]
<nikunj97> hkaiser: found it!
<nikunj97> turns out HPX_LIBRARIES does not include hpx_wrap
<nikunj97> it includes only hpx and hpx_init
<nikunj97> also why is it written as hpx;general;hpx_init
<nikunj97> this is not exactly linking. And it's only with HPX
diehlpk has joined #ste||ar
<nikunj97> hkaiser: it seems to be a cmake situation. I will look into it in deep in the morning.
nikunj97 has quit [Quit: goodnight]
diehlpk has quit [Ping timeout: 240 seconds]
nikunj has joined #ste||ar
<nikunj> hkaiser: the reason why inspect fails is because hpx_wrap is not included in the HPX_LIBRARIES list
<nikunj> only hpx_init and hpx are included
<nikunj> I ran the build and from the verbose error it is clear that hpx_wrap is not linked
<nikunj> hkaiser: I've added it. Just checking things locally
<nikunj> hkaiser: adding hpx_wrap to the list throws error. It says can't find -lhpx_wrap
<hkaiser> nikunj: you need to add general;hpx_wrap
<nikunj> hkaiser: "general;hpx;hpx_wrap;${HPX_LIBRARIES}" This is the change I made
<nikunj> in HPX_GeneratePackage
<hkaiser> no, you need another general; in there, every dependency needs it