hkaiser changed the topic of #ste||ar to: STE||AR: Systems Technology, Emergent Parallelism, and Algorithm Research | stellar-group.org | HPX: A cure for performance impaired parallel applications | github.com/STEllAR-GROUP/hpx | This channel is logged: irclog.cct.lsu.edu
diehlpk has joined #ste||ar
diehlpk has quit [Quit: Leaving.]
hkaiser has quit [Quit: Bye!]
K-ballo has quit [Quit: K-ballo]
<gonidelis[m]>
how do i check if my hpx is built in release or debug mode?
<gnikunj[m]>
Ccmake .
<gnikunj[m]>
And see the output of cmake build type
<gonidelis[m]>
thanks man
Yorlik has joined #ste||ar
Yorlik has quit [Ping timeout: 260 seconds]
Yorlik has joined #ste||ar
diehlpk has joined #ste||ar
diehlpk has quit [Quit: Leaving.]
K-ballo has joined #ste||ar
hkaiser has joined #ste||ar
<ms[m]>
hkaiser: yt? quick question: one of our guys wanted to do some small tests with different mutex types in counting_semaphore
<hkaiser>
ok
<ms[m]>
counting_semaphore is templated on the mutex, but detail::counting_semaphore is not, making the former template parameter useless
<ms[m]>
do you know if this is just an oversight or something else?
<hkaiser>
sec
<hkaiser>
ms[m]: there is the mutex that is used to protect the semaphore, and there is the internal mutex used for the condition_variable
<hkaiser>
ms[m]: hold on - you're right
<hkaiser>
the implementation takes a lock<>, but the type of the lock is fixed :/
<hkaiser>
looks like a bug, indeed
<hkaiser>
good catch
<ms[m]>
hkaiser: ok, thanks, thought so too
<ms[m]>
not a big deal, but still...
<hkaiser>
nod
<ms[m]>
I'll open a pr for that
<hkaiser>
+1
<hkaiser>
thanks
ctaylor_ has quit [Quit: Lost terminal]
diehlpk has joined #ste||ar
diehlpk_work has joined #ste||ar
diehlpk_work has quit [Remote host closed the connection]
<ms[m]>
hkaiser: I'm putting that on hold for now, it turns out it needs a lot of changes, and on top of that it pulls the implementations out of source files :/
<ms[m]>
it might even be that we should put those cpp20_* classes in detail
<ms[m]>
std:counting_semaphore (and hpx::counting_semaphore) are anyway not templated on the mutex
<ms[m]>
we'll discuss things here, but right now I'm not sure it's a good idea to expose that mutex after all
<hkaiser>
ms[m]: ok, fine with me - I think the idea was to do something similar to condition_variable/cv_any - but it was never really thought through