aserio changed the topic of #ste||ar to: STE||AR: Systems Technology, Emergent Parallelism, and Algorithm Research | stellar.cct.lsu.edu | HPX: A cure for performance impaired parallel applications | github.com/STEllAR-GROUP/hpx | Buildbot: http://rostam.cct.lsu.edu/ | Log: http://irclog.cct.lsu.edu/
EverYoung has quit [Ping timeout: 255 seconds]
anushi has quit [Remote host closed the connection]
EverYoun_ has quit [Ping timeout: 276 seconds]
anushi has joined #ste||ar
EverYoung has joined #ste||ar
Anushi1998 has joined #ste||ar
anushi has quit [Ping timeout: 240 seconds]
Anushi1998 has quit [Remote host closed the connection]
Anushi1998 has joined #ste||ar
EverYoung has quit [Remote host closed the connection]
EverYoung has joined #ste||ar
EverYoung has quit [Remote host closed the connection]
EverYoung has joined #ste||ar
EverYoung has quit [Remote host closed the connection]
EverYoung has joined #ste||ar
Anushi1998 has quit [Read error: Connection reset by peer]
parsa has joined #ste||ar
EverYoung has quit [Remote host closed the connection]
EverYoun_ has joined #ste||ar
eschnett has joined #ste||ar
EverYoun_ has quit [Ping timeout: 276 seconds]
EverYoung has joined #ste||ar
EverYoung has quit [Remote host closed the connection]
EverYoung has joined #ste||ar
Anushi1998 has joined #ste||ar
parsa has quit [Quit: Zzzzzzzzzzzz]
kisaacs has quit [Ping timeout: 268 seconds]
parsa has joined #ste||ar
EverYoung has quit [Ping timeout: 260 seconds]
vamatya has quit [Ping timeout: 276 seconds]
kisaacs has joined #ste||ar
hkaiser has quit [Quit: bye]
Anushi1998 has quit [Ping timeout: 260 seconds]
vamatya has joined #ste||ar
vamatya has quit [Read error: Connection reset by peer]
Smasherr has quit [Read error: Connection reset by peer]
Smasher has joined #ste||ar
Anushi1998 has joined #ste||ar
vamatya has joined #ste||ar
kisaacs has quit [Ping timeout: 276 seconds]
Smasher has quit [Ping timeout: 240 seconds]
Nikunj_ has joined #ste||ar
Smasher has joined #ste||ar
kisaacs has joined #ste||ar
kisaacs has quit [Ping timeout: 240 seconds]
parsa has quit [Quit: Zzzzzzzzzzzz]
parsa has joined #ste||ar
vamatya has quit [Ping timeout: 248 seconds]
EverYoung has joined #ste||ar
EverYoung has quit [Read error: Connection reset by peer]
mcopik has joined #ste||ar
EverYoung has joined #ste||ar
gedaj__ has quit [Remote host closed the connection]
gedaj_ has joined #ste||ar
EverYoung has quit [Read error: Connection reset by peer]
simbergm_ has quit [Ping timeout: 255 seconds]
simbergm_ has joined #ste||ar
kisaacs has joined #ste||ar
kisaacs has quit [Ping timeout: 260 seconds]
jaafar has quit [Ping timeout: 240 seconds]
gedaj_ has quit [Read error: Connection reset by peer]
gedaj__ has joined #ste||ar
Anushi1998 has quit [Read error: Connection reset by peer]
Anushi1998 has joined #ste||ar
Anushi1998 has quit [Read error: Connection reset by peer]
Smasher has quit [Ping timeout: 240 seconds]
gedaj__ has quit [Read error: Connection reset by peer]
gedaj__ has quit [Read error: Connection reset by peer]
gedaj_ has joined #ste||ar
Anushi1998 has quit [Remote host closed the connection]
Anushi1998 has joined #ste||ar
eschnett_ has joined #ste||ar
K-ballo1 has joined #ste||ar
K-ballo has quit [Ping timeout: 256 seconds]
eschnett has quit [Ping timeout: 256 seconds]
K-ballo1 is now known as K-ballo
simbergm_ has quit [Ping timeout: 265 seconds]
simbergm_ has joined #ste||ar
apsknight has joined #ste||ar
<Nikunj_>
Hey! So I've added a pull request for issue #3124. Here is what I've done
<Nikunj_>
1) Created CMakeLists.txt in examples/hello_world_component. This will not be ran while running cmake for hpx
<Nikunj_>
2) Inside of circle I am creating another folder named test_component and running cmake script for hello_world_component inside it. This will generate the makefiles.
<Nikunj_>
3) I am then running make inside of that folder. This will run the make and build the component inside of test_component.
<Nikunj_>
NOTE: I am not testing the hello_world_client so formed since I feel that we are more interested in integrating the build into CI rather than testing it as well.
quaz0r has quit [*.net *.split]
<Nikunj_>
In the CMakeLists.txt I did not provide any license headers since I was not sure which ones I had to include.
quaz0r has joined #ste||ar
<Nikunj_>
Also, I did not update the respective readme.rst for hello_world_component since I felt that I'd need help in documenting it
<github>
hpx/master 3c9044d pierrele: white space cleanup
Anushi1998 has quit [Read error: Connection reset by peer]
Anushi1998 has joined #ste||ar
<K-ballo>
Nikunj_: Boost license, anything and everything must have a boost license disclaimer
CaptainRubik has joined #ste||ar
<Nikunj_>
@K-ballo: Ok, I will add a Boost license for CMakeLists.txt and commit the same
<K-ballo>
check the other cmakelist files for inspiration
<Nikunj_>
I have added Boost licence
<Nikunj_>
as for copyright, I found this: Copyright (c) 2011 Bryce Lelbach in readme.rst for hello_world_component. Should the copyright be same for CMakeLists.txt as well?
<hkaiser>
Nikunj_: add yourself in the copyright
<hkaiser>
that's the whole point of it ;)
<Nikunj_>
Ok :)
<Nikunj_>
License headers have been added :)
<hkaiser>
Nikunj_: however, the cmake file you propose does not use the script to build the example, it builds it directly instead
<Nikunj_>
@hkaiser: I did'nt get you. Can you please elaborate.
<hkaiser>
Nikunj_: the cmake script does not generate a build system that invokes the build.sh script
<Nikunj_>
@hkaiser: Oh yes, I have directly integrated it to the build.
<hkaiser>
Nikunj_: didn't we discuss the other day that building the example using the build.sh script was the whole point ?
<Nikunj_>
That's why I switched from creating a build.sh to directly integrating it.
<hkaiser>
Nikunj_: ok
<hkaiser>
heller_: what's your rationale to switch away from the script?
<hkaiser>
Nikunj_: if this is really supposed to directly invoke cmake (instead of the script) then there is no need to restrict things to linux
<Nikunj_>
@hkaiser: The broken example showed itself broken with both pkg-config and cmake. That's why I felt it to integrate directly.
<hkaiser>
understand
<K-ballo>
I don't, was the script itself wrong?
<hkaiser>
K-ballo: I think heller_ wanted to make sure that at least the code compiles (as this was the initial issue)
<Nikunj_>
@hkaiser: As for linux only, I can edit the script to make it work for every operating system.
<hkaiser>
but I hoped for testing the whole thing, frankly
<Nikunj_>
@hkaiser: What should I do now?
<hkaiser>
Nikunj_: let's wait for heller_ to respond, I'd like to hear his side of things
<Nikunj_>
@hkaiser: Ok
mcopik has quit [Ping timeout: 256 seconds]
<Nikunj_>
@hkaiser: Should I work on creating build.sh as a side-work in case we decide to switch to creating build.sh instead?
<hkaiser>
Nikunj_: sure, if you would like to do that?
<Nikunj_>
@hkaiser: Ok, in that case I'll start working on that as well. However, one thing to note, I have mid-semester exams from 19th feb so I won't be able to actively participate from 19-21st feb.
<Nikunj_>
@hkaiser: I will, however, try my best to incorporate the pull request before 19th.
mcopik has joined #ste||ar
<hkaiser>
Nikunj_: no worries - there is no rush to fix this
kisaacs has joined #ste||ar
kisaacs has quit [Ping timeout: 276 seconds]
Anushi1998 has quit [Ping timeout: 260 seconds]
anushi has joined #ste||ar
EverYoung has joined #ste||ar
EverYoung has quit [Ping timeout: 252 seconds]
parsa has joined #ste||ar
nanashi55 has quit [Ping timeout: 248 seconds]
nanashi55 has joined #ste||ar
nanashi55 has quit [Ping timeout: 276 seconds]
nanashi55 has joined #ste||ar
nanashi55 has quit [Ping timeout: 256 seconds]
nanashi55 has joined #ste||ar
gedaj__ has joined #ste||ar
gedaj_ has quit [Remote host closed the connection]
jaafar has joined #ste||ar
nanashi55 has quit [Ping timeout: 248 seconds]
nanashi55 has joined #ste||ar
diehlpk has joined #ste||ar
kisaacs has joined #ste||ar
anushi has quit [Ping timeout: 252 seconds]
kisaacs has quit [Ping timeout: 276 seconds]
kisaacs has joined #ste||ar
gedaj__ has quit [Read error: Connection reset by peer]
gedaj_ has joined #ste||ar
nanashi55 has quit [Ping timeout: 256 seconds]
nanashi55 has joined #ste||ar
victor_ludorum has joined #ste||ar
diehlpk has quit [Ping timeout: 264 seconds]
gedaj_ has quit [Read error: Connection reset by peer]
gedaj__ has joined #ste||ar
nanashi55 has quit [Ping timeout: 240 seconds]
nanashi55 has joined #ste||ar
gedaj__ has quit [Remote host closed the connection]