aserio changed the topic of #ste||ar to: STE||AR: Systems Technology, Emergent Parallelism, and Algorithm Research | stellar.cct.lsu.edu | HPX: A cure for performance impaired parallel applications | github.com/STEllAR-GROUP/hpx | Buildbot: http://rostam.cct.lsu.edu/ | Log: http://irclog.cct.lsu.edu/
parsa has quit [Quit: Zzzzzzzzzzzz]
<github> [hpx] hkaiser pushed 1 new commit to fixing_2847: https://git.io/v5fao
<github> hpx/fixing_2847 82835bd Hartmut Kaiser: Allowing for non-default-constructible action argument and action return types
ajaivgeorge has joined #ste||ar
jaafar_ has joined #ste||ar
bikineev has quit [Remote host closed the connection]
bikineev has joined #ste||ar
bikineev has quit [Ping timeout: 240 seconds]
ajaivgeorge has quit [Quit: ajaivgeorge]
mcopik has quit [Ping timeout: 255 seconds]
jaafar_ has quit [Ping timeout: 240 seconds]
<github> [hpx] hkaiser force-pushed fixing_2847 from 82835bd to bc7eb90: https://git.io/v5ect
<github> hpx/fixing_2847 bc7eb90 Hartmut Kaiser: Allowing for non-default-constructible action argument and action return types
hkaiser has quit [Quit: bye]
parsa has joined #ste||ar
K-ballo has quit [Quit: K-ballo]
parsa has quit [Quit: Zzzzzzzzzzzz]
parsa has joined #ste||ar
parsa has quit [Client Quit]
parsa has joined #ste||ar
parsa has quit [Ping timeout: 246 seconds]
<heller> ole!
bikineev has joined #ste||ar
bikineev has quit [Ping timeout: 246 seconds]
<jbjnr> ola!
<jbjnr> (I'm just about to go away for a few days, so won't be here much this week)
<jbjnr> hope you had a nice vacation
Matombo has joined #ste||ar
<heller> jbjnr: i did
<heller> how much did I miss?
bikineev has joined #ste||ar
david_pfander has joined #ste||ar
Matombo has quit [Remote host closed the connection]
<github> [hpx] StellarBot pushed 1 new commit to gh-pages: https://git.io/v5fAK
<github> hpx/gh-pages 4c0262b StellarBot: Updating docs
bikineev has quit [Remote host closed the connection]
bikineev has joined #ste||ar
mcopik has joined #ste||ar
Matombo has joined #ste||ar
denis_blank has joined #ste||ar
Matombo has quit [Ping timeout: 248 seconds]
Matombo has joined #ste||ar
bikineev has quit [Ping timeout: 240 seconds]
Matombo has quit [Ping timeout: 240 seconds]
bikineev has joined #ste||ar
hkaiser has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
mcopik has quit [Ping timeout: 240 seconds]
<Vir> hkaiser: I just pushed Vc 1.71
<hkaiser> Vir: ohh, cool!
<Vir> heller: on the master branch...
<Vir> so mkretz/datapar is still 1.70
<heller> nice!
<hkaiser> ohh heller! you're back!
<heller> :D
<heller> for a little while
<heller> need to clean up all the mess that has been created while I was MIA :/
<heller> having a guest from allscale here to make progress ...
<heller> they messed up a bit
<hkaiser> heh
<hkaiser> the mice dance on the table if the cat's away
<heller> also trying to clean up your mess :P
<heller> the channel failure
<hkaiser> heller: also working on it
<heller> ah ok
<hkaiser> but feel free
<heller> hkaiser: do you wanna know what I found out so far?
<hkaiser> tell me
<heller> it looks like there is mismatch in the dynamic type of the created components
<heller> that's what ubsan is telling me
<heller> that is, in simple_component_base.hpp line 304, we cast to the wrong type
K-ballo has joined #ste||ar
<hkaiser> heller: uuh
<hkaiser> what test do you look at?
<heller> hkaiser: tests/unit/lcos/channel.cpp
<hkaiser> k, will look closer
eschnett has quit [Quit: eschnett]
<heller> hkaiser: nice. coverage increases
<hkaiser> nod, we're listed as well ;)
<heller> now, we only need a green buildbot :P
<hkaiser> come on
<hkaiser> things have improved massively over the last days
<heller> did it ;)?
<hkaiser> yes
<heller> ok
<heller> I obviously only looked at it today
<hkaiser> believe me, I'm working hard on this front
<heller> I know
<heller> what I am really hinting at that our PRs should be tested more thoroughly
<hkaiser> heller: absolutely
<hkaiser> compiling is obviously not sufficient
<heller> no
<heller> and it is frustrating to have it breaking almost every other merge
<heller> this current failure is very strange though :/
hkaiser has quit [Read error: Connection reset by peer]
eschnett has joined #ste||ar
hkaiser has joined #ste||ar
<hkaiser> heller: not having anybody to review PRs is not helping the issue either
<heller> hkaiser: yes :/
<heller> hkaiser: I am back now ...
<heller> but even manual code review doesn't catch everything
<heller> hkaiser: but I am still thinking that we should only start merging stuff once we have a (almost) green master branch ,)
<hkaiser> sure, that's what I'm doing
eschnett has quit [Quit: eschnett]
hkaiser has quit [Quit: bye]
eschnett has joined #ste||ar
eschnett has quit [Ping timeout: 240 seconds]
eschnett has joined #ste||ar
mcopik has joined #ste||ar
hkaiser has joined #ste||ar
<heller> hkaiser: got it fixed!
<heller> Will commit the fix later today
hkaiser has quit [Ping timeout: 276 seconds]
hkaiser has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
<hkaiser> heller: I got the channel fixed - stupid typo after all
parsa has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
david_pfander has quit [Ping timeout: 246 seconds]
pree has joined #ste||ar
parsa has quit [Read error: Connection reset by peer]
pree has quit [Read error: Connection reset by peer]
parsa| has joined #ste||ar
pree has joined #ste||ar
<github> [hpx] hkaiser pushed 1 new commit to master: https://git.io/v5JVT
<github> hpx/master 4cb1934 Hartmut Kaiser: Fixing channel test
hkaiser has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
bikineev has quit [Ping timeout: 240 seconds]
parsa| has quit [Read error: Connection reset by peer]
parsa has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
parsa has quit [Read error: Connection reset by peer]
parsa has joined #ste||ar
hkaiser has joined #ste||ar
bikineev has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
parsa has quit [Read error: Connection reset by peer]
hkaiser_ has joined #ste||ar
parsa| has joined #ste||ar
hkaiser_ has quit [Read error: Connection reset by peer]
hendrx has joined #ste||ar
parsa| has quit [Read error: Connection reset by peer]
parsa has joined #ste||ar
jaafar_ has joined #ste||ar
hkaiser has joined #ste||ar
parsa has quit [Read error: Connection reset by peer]
parsa has joined #ste||ar
parsa has quit [Client Quit]
parsa has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
<K-ballo> interesting... what about an indecisive codebase with different styles per file?
<K-ballo> mispoke, not per file
hkaiser has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
EverYoung has joined #ste||ar
<zao> (tool brute-forces possible settings by trying to format all the files indicated and picking the least mutating results)
pree has quit [Ping timeout: 276 seconds]
pree has joined #ste||ar
parsa has quit [Read error: Connection reset by peer]
parsa| has joined #ste||ar
hkaiser has quit [Ping timeout: 240 seconds]
parsa| has quit [Read error: Connection reset by peer]
parsa has joined #ste||ar
hkaiser has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
<github> [hpx] hkaiser pushed 1 new commit to master: https://git.io/v5J1L
<github> hpx/master 7a01561 Hartmut Kaiser: Attempting to fix shared_future test
<heller> hkaiser: actually, it's a bit more than that
<heller> hkaiser: base_lco_with_value is not derived from any of the components.
hkaiser has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
<hkaiser> heller: it shouldn't be
<heller> hkaiser: sure, look at how it is created though new_ though
<heller> we static_cast to component_type and then back to Component
hkaiser_ has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
parsa has quit [Read error: Connection reset by peer]
parsa has joined #ste||ar
<heller> hkaiser_: I'll commit what I have in an hour or two
<hkaiser_> heller: I don't think base_lco_with_value should be derived from a component base class
<github> [hpx] hkaiser pushed 1 new commit to partitioned_vector: https://git.io/v5JDx
<github> hpx/partitioned_vector a6749f7 Hartmut Kaiser: Merge branch 'master' into partitioned_vector
hkaiser_ has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
<heller> hkaiser: I agree, it shouldn't
hkaiser_ has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
parsa has quit [Read error: Connection reset by peer]
parsa| has joined #ste||ar
hkaiser_ has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
parsa has joined #ste||ar
parsa| has quit [Ping timeout: 255 seconds]
parsa has quit [Read error: Connection reset by peer]
hkaiser has quit [Read error: Connection reset by peer]
parsa has joined #ste||ar
hkaiser has joined #ste||ar
parsa has quit [Read error: Connection reset by peer]
<denis_blank> hkaiser: Do you know why futures are invalidated after those were passed to the dataflow evaluation function? https://github.com/STEllAR-GROUP/hpx/blob/master/hpx/lcos/dataflow.hpp#L221-L225 (also there is a double move)
<heller> denis_blank: the reset was to break cycles
parsa has joined #ste||ar
<denis_blank> heller: when are such cycles occuring?
hkaiser_ has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
parsa has quit [Read error: Connection reset by peer]
parsa| has joined #ste||ar
parsa| has quit [Read error: Connection reset by peer]
hkaiser_ has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
parsa has joined #ste||ar
parsa has quit [Read error: Connection reset by peer]
parsa| has joined #ste||ar
hkaiser_ has joined #ste||ar
EverYoung has quit [Ping timeout: 246 seconds]
<hkaiser_> denis_blank: because futures are move-only and they are moved into the callback
hkaiser has quit [Read error: Connection reset by peer]
hkaiser_ has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
parsa| has quit [Read error: Connection reset by peer]
<hkaiser> denis_blank: yah, good catch - this needs fixing
parsa has joined #ste||ar
<K-ballo> ?
<hkaiser> K-ballo: use of a moved away tuple
<K-ballo> I don't see an issue with that
<hkaiser> see line 218
<K-ballo> yes, I see the full picture, I don't see an issue with it
<hkaiser> hmm, I do see a problem
<denis_blank> hkaiser: I removed it in my local copy already. I'll mention it in the upcoming PR again, so we can discuss about this in detail.
<hkaiser> ok
<K-ballo> in which situation would it be problematic?
hkaiser has quit [Read error: Connection reset by peer]
hkaiser_ has joined #ste||ar
* K-ballo has a vague recollection of having removed this and later putting it back in
<K-ballo> say you call dataflow([](auto const& sf) {}, shared_future(...));, without the reset the decayed-copy of the shared future argument is artificially extended to the end of the dataflow frame lifetime
hkaiser_ has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
<K-ballo> er, I meant to say it artificially extends the lifetime of the shared state
EverYoung has joined #ste||ar
<hkaiser> K-ballo: if the dataflow callback takes the futures by value the reset accesses a zombie future
<hkaiser> isn't that UB?
<K-ballo> no, it's a valid but unspecified state
<K-ballo> in particular re-assignment is well defined
<hkaiser> well yah, it's re-assigned only
<heller> denis_blank: for shared_futures, you might get cycles
hkaiser has quit [Read error: Connection reset by peer]
<K-ballo> at the very least I remember strongly wanting to remove it
parsa has quit [Read error: Connection reset by peer]
parsa| has joined #ste||ar
parsa| has quit [Remote host closed the connection]
parsa has joined #ste||ar
<denis_blank> Mh ok, I'll leave it as it is, however I have to reset the futures inside nested packs then...
hkaiser has joined #ste||ar
parsa has quit [Read error: Connection reset by peer]
parsa| has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
<heller> K-ballo: yup. Me too
hkaiser has joined #ste||ar
bikineev has quit [Read error: No route to host]
bikineev has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
<K-ballo> heller: do you remember if it breaks one of the examples or something like that?
hkaiser has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
parsa| has quit [Read error: Connection reset by peer]
parsa has joined #ste||ar
hkaiser_ has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
parsa has quit [Read error: Connection reset by peer]
parsa| has joined #ste||ar
<github> [hpx] hkaiser pushed 1 new commit to fixing_2847: https://git.io/v5JAL
<github> hpx/fixing_2847 aa5bf3e Hartmut Kaiser: Fixing C++11 compatibility issue
hkaiser_ has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
<K-ballo> we don't have a constexpr friendly HPX_ASSERT?
<hkaiser> K-ballo: no
parsa| has quit [Read error: Connection reset by peer]
parsa has joined #ste||ar
<pree> HPX_ASSERT == assert ===> 1 right ?
<heller> K-ballo: iirc it breaks the stencil applications
<pree> not a static_assert
EverYoun_ has joined #ste||ar
parsa has quit [Read error: Connection reset by peer]
parsa has joined #ste||ar
EverYoung has quit [Ping timeout: 246 seconds]
hkaiser has quit [Read error: Connection reset by peer]
hkaiser has joined #ste||ar
<hkaiser> heller: ok, the channel test passes now
bikineev has quit [Remote host closed the connection]
hkaiser_ has joined #ste||ar
hkaiser has quit [Ping timeout: 240 seconds]
parsa has quit [Read error: Connection reset by peer]
parsa has joined #ste||ar
EverYoun_ has quit [Remote host closed the connection]
EverYoung has joined #ste||ar
parsa has quit [Ping timeout: 255 seconds]
hkaiser_ has quit [Ping timeout: 276 seconds]
hkaiser has joined #ste||ar
hkaiser has quit [Read error: Connection reset by peer]
bikineev has joined #ste||ar
pree has quit [Ping timeout: 276 seconds]
hkaiser has joined #ste||ar
<github> [hpx] hkaiser force-pushed fixing_2847 from aa5bf3e to 7d428a2: https://git.io/v5ect
<github> hpx/fixing_2847 7d428a2 Hartmut Kaiser: Fixing C++11 compatibility issue
pree has joined #ste||ar
bikineev has quit [Remote host closed the connection]
<pree> I got it " hpx::get_os_thread_count() ".
<pree> wait sec
<pree> whether this taken "hyper threading into account ??
<pree> any ^^
bikineev has joined #ste||ar
parsa has joined #ste||ar
pree has quit [Ping timeout: 276 seconds]
<hkaiser> heller: yay! first builders are green!
<github> [hpx] hkaiser pushed 2 new commits to master: https://git.io/v5UTH
<github> hpx/master 5368318 Taeguk Kwon: Fix a strange thing in parallel::util::detail::handle_local_exceptions. (Fix #2818)
<github> hpx/master 19453bd Hartmut Kaiser: Merge pull request #2832 from taeguk/tg_fix_2818...
parsa has quit [Ping timeout: 246 seconds]
pree has joined #ste||ar
Matombo has joined #ste||ar
denis_blank has quit [Quit: denis_blank]
pree has quit [Ping timeout: 276 seconds]
pree has joined #ste||ar
<github> [hpx] ShmuelLevine opened pull request #2853: Update Table 17. Non-modifying Parallel Algorithms in Documentation (master...patch-1) https://git.io/v5UZL
eschnett has quit [Quit: eschnett]
<github> [hpx] hkaiser force-pushed fixing_2847 from 7d428a2 to 13525b2: https://git.io/v5ect
<github> hpx/fixing_2847 13525b2 Hartmut Kaiser: Fixing C++11 compatibility issue
pree has quit [Ping timeout: 276 seconds]
pree has joined #ste||ar
pree has quit [Ping timeout: 276 seconds]
hendrx has quit [Ping timeout: 260 seconds]
<heller> hkaiser: this still leads to diagnostics when running with ubsan
bikineev_ has joined #ste||ar
bikineev has quit [Ping timeout: 248 seconds]
mcopik has quit [Ping timeout: 240 seconds]
<heller> hkaiser: you'll see the complete PR tomorrow, I'm still not entirely sure if it's too pedantic though
<heller> But failing with ubsan is not a good feat
mcopik has joined #ste||ar
jaafar_ has quit [Quit: Konversation terminated!]
jaafar has joined #ste||ar
<github> [hpx] Dekken opened pull request #2854: Support ARM64 in timestamps (master...master) https://git.io/v5U2O
mcopik has quit [Ping timeout: 240 seconds]
EverYoun_ has joined #ste||ar
EverYoung has quit [Ping timeout: 246 seconds]
EverYoun_ has quit [Ping timeout: 246 seconds]
EverYoung has joined #ste||ar
EverYoung has quit [Remote host closed the connection]
EverYoung has joined #ste||ar