01:30 <heller> hkaiser: I guess we are totally not on the same page ;)

01:35 <heller> hkaiser: all I am trying to say is that that !localities_ case was encoded in the condition localities_.empty() (prior to your PR). Now localities_ should never be empty, and the empty case is coerced into the case where the size of the vector is 1

01:39 <heller> and now, in the "empty" case, we create a shared pointer of a vector holding one id_type just to destroy right away after we checked that it's "empty"

01:39 <heller> I might miss something ...

01:45 <hkaiser> heller: I think th eold behavior was not correct

01:45 <heller> ok

01:45 <heller> the tests we have seem to pass

01:45 <github> [hpx] hkaiser force-pushed fixing_3054 from 627b901 to ecf6b6f: https://git.io/vb5lI

01:45 <github> hpx/fixing_3054 ecf6b6f Hartmut Kaiser: Unify handling of list of localities...

01:46 <hkaiser> shrug, we don't have any thorough tests for this policy

01:46 <heller> poilcies in general are not heavily used, i guess

01:47 <hkaiser> anyways, pls have another look ^^

01:48 <heller> hkaiser: https://github.com/STEllAR-GROUP/hpx/commit/ecf6b6fe472b1943c5d518d78a0a950cf2f5591c#diff-d5ecad95e3a21b4ec402144d1b42d637R91 <-- (std::max) shouldn't be needed here anymoer

01:49 <hkaiser> fair enough

01:49 <hkaiser> well, num_partitions_ could be zero, I guess

01:49 <heller> hmm

01:49 <heller> ok

01:49 <heller> doesn't hurt

01:50 <heller> here is the thing that I don't like about the PR: In the case of a default constructed policy, ensure_localities is being called over and over again

01:50 <hkaiser> no

01:50 <hkaiser> only for the container_policy

01:50 <hkaiser> I removed it completly from the default_policy

01:51 <heller> ahh, you changed it back, great

01:52 <heller> now we are on the same page ;)

01:53 <hkaiser> I can remove it from one more spot

02:01 <github> [hpx] hkaiser force-pushed fixing_3054 from ecf6b6f to 0995a14: https://git.io/vb5lI

02:01 <github> hpx/fixing_3054 0995a14 Hartmut Kaiser: Unify handling of list of localities...

02:06 <github> [hpx] hkaiser pushed 5 new commits to master: https://git.io/vbNwA

02:06 <github> hpx/master 8cbeba5 Taeguk Kwon: Implement parallel::remove and parallel::remove_if....

02:06 <github> hpx/master c14af9f Taeguk Kwon: Add unit tests for parallel::remove and parallel::remove_if.

02:06 <github> hpx/master 1a3dc54 Taeguk Kwon: Add container version of parallel::remove and parallel::remove_if. And add unit tests for them....

10:06 <github> [hpx] StellarBot pushed 1 new commit to gh-pages: https://git.io/vbNSX

10:06 <github> hpx/gh-pages 8c78642 StellarBot: Updating docs

13:05 <github> [hpx] hkaiser force-pushed fixing_3054 from 0995a14 to 3c49dd9: https://git.io/vb5lI

13:05 <github> hpx/fixing_3054 3c49dd9 Hartmut Kaiser: Unify handling of list of localities...